TexturedButtons / Tint Buttons - bugged or bad desig?

[Patrymir]

Here's my issue:

When I use the "Tint buttons" function, and I try to tint buttons that are "On cooldown" what happens is that every single button gets tinted red (red being my color of choice, as in the color I want my buttons to be tinted with when an ability is on CD) for about 1.5s. So! It reads the Global Cooldown (GCD) as a normal Cooldown!

What's worse, and this is the second issue, is that after using any ability it keeps semi-permanently coloring buttons that are not on CD! This mostly involves abilities that require a second resource, in my case that's Hatred. This coloring isn't even consistent! For example Furious Howl stays colored dark red while Pitiless Strike goes back to the default color on its own after a while.

Does anyone know how to change the code to at least stop TexturedButtons from treating GCD and CD as the same thing? So on a GCD it can stop tinting all icons red all the time and just tint the actual, normal cooldowns? The effect as it is right now is extremely distracting, I can't even say if this is just a poor design decision or a bug.

[Patrymir]

Now, I'm no coding guru, but just a moment ago I figured out how to make a fix for both issues. I came up with this after several days of none stop logging in and out, due to the testing other solution, but none of them was as good or as simple as this one.

Open up TexturedButtons.lua
Go to line 1164
You should see something like this:

Code: Select all

if (cooldownSettings.EnableButtonTinting and tintSettings.Enabled) then

Change that to:

Code: Select all

if (cooldownSettings.EnableButtonTinting and tintSettings.Enabled and self.m_MaxCooldown >= 1.6) then

On my end it removed all of that random coloring and GCD flashes of all icons.

Small Update:

While this does work, there is a pretty serious downside, which I have no idea how to resolve:

When you are quickly pressing your keys, the buttons that are on cooldown will remain tinted, once you slow down your key presses, they go back to normal.

If anyone out there knows a better solution than mine, please post it here.