Return of Reckoning

Other than health pots, as a SnB tank BO what should I be using for buff potions? I get both armor and toughness skill buff so will those cancel out the armor/toughness potions? Strength the only one? Thanks.

depends what you're doing and how fancy you wanna be, but yes the pots and your self buffs do not stack

tough pot - nice in orvr and funnels as you're mostly just getting shot or channelling and so are unlikely to get your tough buff up
str pot - good for scs where keeping the tough buff up is easy and the extra toughness isn't that big of a deal anyway

armour - same as tough in orvr, using a pot just means it's always up and you don't have to worry about it
resist pot - nice in SCs where keeping your armour buff up is easy and you're unlikely to be getting focused by melee anyway. keep in mind shamans buff this anyway and shaman is a very popular sc class, so potting a certain kind of resist just for scs is more of a roaming dont-wanna-get-instasploded dps tank thing

another thing to consider is that every GCD you can save on a tank is worth a lot as you have so many useful things to do with each one (guardswapping, challenging, interrupting, punting, CCing, debuffing, shattering.) on BO you often need to spend a GCD on your non target abilities just to shift too. therefore if you wanna be ultra effective as an MT and don't really care about maximizing your damage just getting the tough and armour buff abilities out of your rotation by running the pots is also worth it - it simplifies what you're doing and lets you focus on more important stuff

As shield BO you can actually ignore these potions - because damage-wise you are useless anyway and will be attacked only when your team is already dead - and at this point it's irrelevant.

Toughness/- chance to be crit is a way to go in oRvR. But again, if you are spamming Can't Hit me+whatever useful stuff you have, you are probably outlive your team.

great feedback, thank you.

well if you are not interested in armor/resistance potions you can always go for thorn potions, a better version of this:
https://www.returnofreckoning.com/armory/item/3003279