Return of Reckoning

Looks like this broke with the recent ability system changes and the icon no longer changes. Please could you update it with the new IDs?

Looks like it is doing like every addon is since the update, it is not updating correctly as if the event handlers are not working

Omegus wrote: Fri Dec 15, 2023 9:44 pm Looks like this broke with the recent ability system changes and the icon no longer changes. Please could you update it with the new IDs?

It wasn't the ID, it was that the toggle of the ability doesn't register as a cast when toggle off, However, did a crude workaround and updated the file on 1:st page

sullemunk wrote: Fri Dec 15, 2023 11:39 pm

Omegus wrote: Fri Dec 15, 2023 9:44 pm Looks like this broke with the recent ability system changes and the icon no longer changes. Please could you update it with the new IDs?

It wasn't the ID, it was that the toggle of the ability doesn't register as a cast when toggle off, However, did a crude workaround and updated the file on 1:st page

Just gave it a try and it only now seems to work if Harbinger is in an ability slot that has a shortcut key assigned to it. I assume that was part of the crude workaround for now?

Wow, great addon! How come I only found out it about it today?! Thank you, Sulle.

Dont know if it's of any interest to you, but I think most Zs/RPs are only interested to see whether or not you have DPS mode on. Thus showing the healing mode is a bit redundant. As a quick and dirty workaround for this I just deleted the 'heal' portions from the images, leaving transparent canvas in its place. But maybe it could be incorporated into addon?

Omegus wrote: Sat Dec 16, 2023 12:34 am

sullemunk wrote: Fri Dec 15, 2023 11:39 pm

Omegus wrote: Fri Dec 15, 2023 9:44 pm Looks like this broke with the recent ability system changes and the icon no longer changes. Please could you update it with the new IDs?

It wasn't the ID, it was that the toggle of the ability doesn't register as a cast when toggle off, However, did a crude workaround and updated the file on 1:st page

Just gave it a try and it only now seems to work if Harbinger is in an ability slot that has a shortcut key assigned to it. I assume that was part of the crude workaround for now?

It only checks for the first 60 slots (hotbars 1-5)

sullemunk wrote: Sat Dec 16, 2023 5:15 pm

Omegus wrote: Sat Dec 16, 2023 12:34 am

sullemunk wrote: Fri Dec 15, 2023 11:39 pm

It wasn't the ID, it was that the toggle of the ability doesn't register as a cast when toggle off, However, did a crude workaround and updated the file on 1:st page

Just gave it a try and it only now seems to work if Harbinger is in an ability slot that has a shortcut key assigned to it. I assume that was part of the crude workaround for now?

It only checks for the first 60 slots (hotbars 1-5)

Sorry, that bug report was rubbish. I've re-tested and it mostly only works on action bar 1. 2-5 causes Lua errors in OnUpdate. If you move the ability from bar 1 to a different one it will trigger the error, logged to line 73.

Omegus wrote: Sat Dec 16, 2023 8:08 pm

sullemunk wrote: Sat Dec 16, 2023 5:15 pm

Omegus wrote: Sat Dec 16, 2023 12:34 am

Just gave it a try and it only now seems to work if Harbinger is in an ability slot that has a shortcut key assigned to it. I assume that was part of the crude workaround for now?

It only checks for the first 60 slots (hotbars 1-5)

Sorry, that bug report was rubbish. I've re-tested and it mostly only works on action bar 1. 2-5 causes Lua errors in OnUpdate. If you move the ability from bar 1 to a different one it will trigger the error, logged to line 73.

Yeah, Had to math.mod it with 12