Page 1 of 6

WSCT replacement

Posted: Sun Apr 26, 2020 12:16 pm
by Phantasm
I have to replace WSCT cause it makes huge lag spikes and freezes when fight in massive battles, tried to tweak it down, but nothing works especially against PnP 5s freeze on combat engage guaranteed:)
I came back to default combat text but those numbers are so small on 3440x1440 screen, is there any way to make them bigger? any addon for that? file editing? I tried Ragnarok Style addon but combat text is attached to my character so meh.

Re: WSCT replacement

Posted: Sun Apr 26, 2020 12:29 pm
by Wdova
I turned it off to, because stability and fps increase is significant especialy at large keep and fort fights. Using base ones at 1440p and its fine.

Re: WSCT replacement

Posted: Sun Apr 26, 2020 3:13 pm
by wdesu
you can try this https://gitlab.com/nwwdles/war-addons/- ... ttextnames if you want. it's basically a couple of hooks on the EA combat text to change fonts etc. it doesn't support skill icons, only skill names. it shouldn't have significant overhead over the default combat text but don't quote me on that.

edit: got a shorter username and changed gitlab link

Re: WSCT replacement

Posted: Sun Apr 26, 2020 8:08 pm
by Phantasm
wdesu wrote: Sun Apr 26, 2020 3:13 pm you can try this https://gitlab.com/cupnoodles14/war-add ... ttextnames if you want. it's basically a couple of hooks on the EA combat text to change fonts etc. it doesn't support skill icons, only skill names. it shouldn't have significant overhead over the default combat text but don't quote me on that.
Thanks a lot, that looks like what i was looking for. I`ll test it tomorrow.

Re: WSCT replacement

Posted: Tue Apr 28, 2020 1:59 pm
by Secrets
These LUA events have been a large source of framerate drops. Even the default EA ones suck. I don't think there's a totally easy solution here, but you can try unhooking the default events if you exhaust your options.

Won't look as pretty but it'll give you frames.

Make the changes in wsct.lua:

Code: Select all

-------------------------
--Regsiter WSCT with all events
function WSCT:RegisterSelfEvents()
  UnregisterEventHandler( SystemData.Events.WORLD_OBJ_COMBAT_EVENT, "EA_System_EventText.AddCombatEventText")
  UnregisterEventHandler( SystemData.Events.WORLD_OBJ_XP_GAINED, "EA_System_EventText.AddXpText")
  UnregisterEventHandler( SystemData.Events.WORLD_OBJ_RENOWN_GAINED, "EA_System_EventText.AddRenownText")
  UnregisterEventHandler( SystemData.Events.WORLD_OBJ_INFLUENCE_GAINED, "EA_System_EventText.AddInfluenceText")

  -- RegisterEventHandler(SystemData.Events.WORLD_OBJ_COMBAT_EVENT, "WSCT.OnCombatEvent")
  -- RegisterEventHandler(SystemData.Events.PLAYER_COMBAT_FLAG_UPDATED, "WSCT.PLAYER_COMBAT_FLAG_UPDATED")
  -- RegisterEventHandler(SystemData.Events.WORLD_OBJ_XP_GAINED, "WSCT.WORLD_OBJ_XP_GAINED")
  -- RegisterEventHandler(SystemData.Events.WORLD_OBJ_RENOWN_GAINED, "WSCT.WORLD_OBJ_RENOWN_GAINED")
  -- RegisterEventHandler(SystemData.Events.WORLD_OBJ_INFLUENCE_GAINED, "WSCT.WORLD_OBJ_INFLUENCE_GAINED")
  -- RegisterEventHandler(SystemData.Events.PLAYER_CUR_HIT_POINTS_UPDATED, "WSCT.PLAYER_CUR_HIT_POINTS_UPDATED")
  -- RegisterEventHandler(SystemData.Events.PLAYER_MORALE_UPDATED, "WSCT.PLAYER_MORALE_UPDATED")
  -- RegisterEventHandler(SystemData.Events.PLAYER_EFFECTS_UPDATED, "WSCT.PLAYER_EFFECTS_UPDATED")
  -- RegisterEventHandler(SystemData.Events.PLAYER_CUR_ACTION_POINTS_UPDATED, "WSCT.PLAYER_CUR_ACTION_POINTS_UPDATED")
  -- RegisterEventHandler(SystemData.Events.PLAYER_CAREER_RESOURCE_UPDATED, "WSCT.PLAYER_CAREER_RESOURCE_UPDATED")
end

-------------------------
--Unregsiter WSCT with all events
function WSCT:UnregisterSelfEvents()
  -- UnregisterEventHandler(SystemData.Events.WORLD_OBJ_COMBAT_EVENT, "WSCT.OnCombatEvent")
  -- UnregisterEventHandler(SystemData.Events.PLAYER_COMBAT_FLAG_UPDATED, "WSCT.PLAYER_COMBAT_FLAG_UPDATED")
  -- UnregisterEventHandler(SystemData.Events.WORLD_OBJ_XP_GAINED, "WSCT.WORLD_OBJ_XP_GAINED")
  -- UnregisterEventHandler(SystemData.Events.WORLD_OBJ_RENOWN_GAINED, "WSCT.WORLD_OBJ_RENOWN_GAINED")
  -- UnregisterEventHandler(SystemData.Events.WORLD_OBJ_INFLUENCE_GAINED, "WSCT.WORLD_OBJ_INFLUENCE_GAINED")
  -- UnregisterEventHandler(SystemData.Events.PLAYER_CUR_HIT_POINTS_UPDATED, "WSCT.PLAYER_CUR_HIT_POINTS_UPDATED")
  -- UnregisterEventHandler(SystemData.Events.PLAYER_MORALE_UPDATED, "WSCT.PLAYER_MORALE_UPDATED")
  -- UnregisterEventHandler(SystemData.Events.PLAYER_EFFECTS_UPDATED, "WSCT.PLAYER_EFFECTS_UPDATED")
  -- UnregisterEventHandler(SystemData.Events.PLAYER_CUR_ACTION_POINTS_UPDATED, "WSCT.PLAYER_CUR_ACTION_POINTS_UPDATED")
  -- UnregisterEventHandler(SystemData.Events.PLAYER_CAREER_RESOURCE_UPDATED, "WSCT.PLAYER_CAREER_RESOURCE_UPDATED")

  RegisterEventHandler( SystemData.Events.WORLD_OBJ_COMBAT_EVENT, "EA_System_EventText.AddCombatEventText")
  RegisterEventHandler( SystemData.Events.WORLD_OBJ_XP_GAINED, "EA_System_EventText.AddXpText")
  RegisterEventHandler( SystemData.Events.WORLD_OBJ_RENOWN_GAINED, "EA_System_EventText.AddRenownText")
  RegisterEventHandler( SystemData.Events.WORLD_OBJ_INFLUENCE_GAINED, "EA_System_EventText.AddInfluenceText")
end

Re: WSCT replacement

Posted: Tue Apr 28, 2020 2:34 pm
by uanaka
wdesu wrote: Sun Apr 26, 2020 3:13 pm you can try this https://gitlab.com/cupnoodles14/war-add ... ttextnames if you want. it's basically a couple of hooks on the EA combat text to change fonts etc. it doesn't support skill icons, only skill names. it shouldn't have significant overhead over the default combat text but don't quote me on that.
Thanks so much, I've also been struggling with frame issues and I had to disable WSCT. Just quick question, does the text just show up next to the default numbers? One thing I really liked about WSCT is that if I was healing, I could see the heal numbers pop up as opposed to having to look at everyone individually

Re: WSCT replacement

Posted: Wed Apr 29, 2020 2:29 am
by Phantasm
wdesu wrote: Sun Apr 26, 2020 3:13 pm you can try this https://gitlab.com/cupnoodles14/war-add ... ttextnames if you want. it's basically a couple of hooks on the EA combat text to change fonts etc. it doesn't support skill icons, only skill names. it shouldn't have significant overhead over the default combat text but don't quote me on that.

Can you add /script or tell me how to disable names and leave only numbers? Everything else is perfect, inc exp/rp/inf, size and font of dmg, just need to disable names.

Re: WSCT replacement

Posted: Wed Apr 29, 2020 9:37 am
by voina817
Phantasm wrote: Wed Apr 29, 2020 2:29 am
wdesu wrote: Sun Apr 26, 2020 3:13 pm you can try this https://gitlab.com/cupnoodles14/war-add ... ttextnames if you want. it's basically a couple of hooks on the EA combat text to change fonts etc. it doesn't support skill icons, only skill names. it shouldn't have significant overhead over the default combat text but don't quote me on that.

Can you add /script or tell me how to disable names and leave only numbers? Everything else is perfect, inc exp/rp/inf, size and font of dmg, just need to disable names.

Maybe you can try this...

just change one word in combattextnames.lua

--------------------------------------------------------------------------------------------------------------------------------
function CombatTextNames.AddCombatEventText(hitTargetObjectNumber, hitAmount,
textType, abilityID)
-- skip incoming events if they're toggled off
if (hitTargetObjectNumber == GameData.Player.worldObjNum) and
((hitAmount < 0 and not CombatTextNames.IncomingDamageEnabled) or
(hitAmount > 0 and not CombatTextNames.IncomingHealsEnabled) or
(hitAmount == 0 and not CombatTextNames.IncomingMissesEnabled)) then
return
end

local data = GetAbilityData(hitAmount) <----This word ( abilityID -> hitAmount )

-- The SetupText that sets the text to display function is going to receive
-- only eventData.amount member. So we replace eventData.amount with a table
-- that contains all the data we need. That is, we add ability name there.
local eventData = {
event = COMBAT_EVENT,
amount = {
hit = hitAmount,
name = data.name,
abilityID = abilityID,
iconNum = data.iconNum
},
type = textType
}

Re: WSCT replacement

Posted: Wed Apr 29, 2020 9:50 am
by sullemunk
voina817 wrote: Wed Apr 29, 2020 9:37 am
Phantasm wrote: Wed Apr 29, 2020 2:29 am
wdesu wrote: Sun Apr 26, 2020 3:13 pm you can try this https://gitlab.com/cupnoodles14/war-add ... ttextnames if you want. it's basically a couple of hooks on the EA combat text to change fonts etc. it doesn't support skill icons, only skill names. it shouldn't have significant overhead over the default combat text but don't quote me on that.

Can you add /script or tell me how to disable names and leave only numbers? Everything else is perfect, inc exp/rp/inf, size and font of dmg, just need to disable names.

Maybe you can try this...

just change one word in combattextnames.lua

--------------------------------------------------------------------------------------------------------------------------------
function CombatTextNames.AddCombatEventText(hitTargetObjectNumber, hitAmount,
textType, abilityID)
-- skip incoming events if they're toggled off
if (hitTargetObjectNumber == GameData.Player.worldObjNum) and
((hitAmount < 0 and not CombatTextNames.IncomingDamageEnabled) or
(hitAmount > 0 and not CombatTextNames.IncomingHealsEnabled) or
(hitAmount == 0 and not CombatTextNames.IncomingMissesEnabled)) then
return
end

local data = GetAbilityData(hitAmount) <----This word ( abilityID -> hitAmount )

-- The SetupText that sets the text to display function is going to receive
-- only eventData.amount member. So we replace eventData.amount with a table
-- that contains all the data we need. That is, we add ability name there.
local eventData = {
event = COMBAT_EVENT,
amount = {
hit = hitAmount,
name = data.name,
abilityID = abilityID,
iconNum = data.iconNum
},
type = textType
}
I suggest just changing
name = data.name,
To
name = L"",

Re: WSCT replacement

Posted: Wed Apr 29, 2020 12:42 pm
by repel
Phantasm wrote: Sun Apr 26, 2020 12:16 pm I have to replace WSCT cause it makes huge lag spikes and freezes when fight in massive battles, tried to tweak it down, but nothing works especially against PnP 5s freeze on combat engage guaranteed:)
I came back to default combat text but those numbers are so small on 3440x1440 screen, is there any way to make them bigger? any addon for that? file editing? I tried Ragnarok Style addon but combat text is attached to my character so meh.
I dont use wsct for a long time cause i changed default EA addon EASystem_EventText. It shows ability icons now and i increased font size a bit.
Link: https://drive.google.com/file/d/1I1Dt5V ... sp=sharing